binbashar / le-docker-leverage-toolbox

Docker image for https://github.com/binbashar/leverage
3 stars 0 forks source link

Enhancement | automatically enter code when aws sso login #36

Closed juanmatias closed 1 year ago

juanmatias commented 1 year ago

Describe the Enhancement

When using AWS CLI doing:

aws sso login

A webpage is automatically opened, and the generated code is sent to it by the AWS CLI. (i.e. no need to enter it manually)

When doing the same from leverage:

leverage aws sso login

The same webpage is opened but the code is not sent automatically.

Expected Behavior

The behavior should be the same, whenever possible, in both cases.

Use Case

A user trying to use the SSO Login feature.

Describe Ideal Solution

The ideal solution is when opening the webpage the code is entered automatically.

Alternatives Considered

Since Leverage CLI is not trapping the open command from the AWS CLI, it can remain as a manual input.

Additional Context

Take into account the --no-browser for AWS CLI.

exequielrafaela commented 1 year ago

@juanmatias thanks for creating this issue, it sounds like a great UX improvement!

CC: @angelofenoglio @diego-ojeda-binbash