search

binbashar / leverage

Binbash Leverage CLI intended to orchestrate Leverage Reference Architecture for AWS (www.binbash.co/leverage)
https://pypi.org/project/leverage/
Apache License 2.0
17 stars 2 forks source link

Enhancement | Consider removing AWS Secret Access Key regex check on configure credentials #190

Closed marianod92 closed 10 months ago

marianod92 commented 1 year ago

Describe the Bug

Consider removing the regex validation of AWS credentials (AWS_ACCESS_KEY and AWS_SECRET_ACCESS_KEY) for eventual changes in the format generated by AWS IAM and only check these credentials against the AWS API.

Expected Behavior

Having a regex to validate the AWS_ACCESS_KEY and AWS_SECRET_ACCESS_KEY form may result in an unnecessary error when faced with a change in the format generated by AWS and the need to correct it ASAP in order to be able to configure the leverage-cli credentials. If the credentials are validated directly against the AWS API (REGEX compliant or not) and the AWS API responds ok, it is enough to consider them valid.

Steps to Reproduce

Try this flow configure credentials SECURITY | MANAGEMENT

Additional Context

We have discussed this with @angelofenoglio as a possible improvement and simplification of the credential configuration flow, considering Issue 182

exequielrafaela commented 10 months ago

Even if this could be seen as nice validation to have, for the moment the current supported approach cover our use cases.

We'll close this issue till customer projects or the community require it. This will give more space to work on more urgent fixes and features.