fix: 'AWSCLIContainer' object has no attribute 'common_conf

rynkowsg commented 10 months ago

Problem has been explained in the issue HERE.

What?

It is a small fix after recently merged PR.

Why?

CLI breaks on running leverage credentials configure --type BOOTSTRAP

References

https://github.com/binbashar/leverage/issues/242

Before release

Review the checklist here

exequielrafaela commented 9 months ago

@rynkowsg Thanks a lot for this PR, we'll review it ASAP and keep you updated it.

rynkowsg commented 9 months ago

I tested this change before making PR and it solved my problem described in the issue.

rynkowsg commented 9 months ago

Regarding the failing test it looks like secrets were missing for this job for some reason. Looking at the log it looks aws configure doesn't get values. If they were present, they would be masked with * chars.

2024-02-06T14:05:59.3290702Z [36;1maws configure set aws_access_key_id  --profile bb-deploymaster[0m
2024-02-06T14:05:59.3291399Z [36;1maws configure set aws_secret_access_key  --profile bb-deploymaster[0m
2024-02-06T14:05:59.3292093Z [36;1maws configure set region us-east-1 --profile bb-apps-devstg-devops[0m
2024-02-06T14:05:59.3292853Z [36;1maws configure set output json --profile bb-apps-devstg-devops[0m
2024-02-06T14:05:59.3293640Z [36;1maws configure set role_arn arn:aws:iam:::role/DeployMaster --profile bb-apps-devstg-devops[0m
2024-02-06T14:05:59.3294487Z [36;1maws configure set source_profile bb-deploymaster --profile bb-apps-devstg-devops[0m

binbashar / leverage