[229] Fix issue with --version option

binbashar / leverage

Binbash Leverage CLI intended to orchestrate Leverage Reference Architecture for AWS (www.binbash.co/leverage)

https://pypi.org/project/leverage/

Apache License 2.0

17 stars 2 forks source link

[229] Fix issue with --version option #256

Closed borland667 closed 4 months ago

borland667 commented 5 months ago

What?

When trying to access the root variable and and exception happened, root cannot be accessed because it does not exist.
We have to use else there so we only try to access root when there is no exception happening.
New get_project_root_or_current_dir_path method to get the root of the project path.

Why?

To avoid issues when running leverage --version. Otherwise the command would just exit with an unhandled exception like it is described in the issue.

References

Use closes #229

Before release

Review the checklist here

juanmatias commented 5 months ago

@borland667 Sorry I'm a bit out of this right now... But I have a question... why we are returning the pwd if no project root is found? I mean, binbash Leverage is intended to be used inside a Leverage project context.... isn't it ok returning an error if no root is detected?

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8650773559

Details

0 of 0 changed or added relevant lines in 0 files are covered.
130 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 58.859%

Files with Coverage Reduction	New Missed Lines	%
path.py	19	73.33%
modules/project.py	50	30.86%
modules/credentials.py	61	54.13%
<!--	Total:	130	-->

Totals
Change from base Build 8638597298:	0.2%
Covered Lines:	1243
Relevant Lines:	2019