[159] Fix issue with argument parsing logic for tf apply

[borland667]

What?

• ~Implemented enhanced parsing logic in handle_apply_arguments_parsing to handle Terraform apply command arguments.~
• ~Added support for various argument formats including -var, -var-file, -target, -lock, -parallelism, -compact-warnings, -input, -json, -auto-approve, -no-color, and combinations thereof.~

Simplified solution:

• A different solution to the original ended up being implemented, simpler and more maintainable.
• The idea is to disturb the Terraform arguments the user provides as little as possible previous to passing them to the application, to provide with as a familiar behavior as possible.
• For Leverage Reference Architecture layers to work as intended, leverage cli needs to pass to Terraform the references to specific variable files via the -var-file arguments. These arguments collide with the presence of a plan file argument, so we need to implement logic to detect whether the user provided such argument or not, and then decide whether we need to add the variable file references to the rest of the arguments or not.

Why?

• Enhance robustness and flexibility in handling Terraform apply command arguments.
• Ensure accurate parsing and inclusion of specified arguments while discarding irrelevant or malformed inputs.
• Improve compatibility with diverse use cases and user input scenarios.
• Address user feedback regarding parsing inconsistencies and edge cases.

References

• Use closes #159, if this PR closes a GitHub issue #159

Before release

Review the checklist here

[coveralls]

Pull Request Test Coverage Report for Build 9584808751

Details

• 44 of 63 (69.84%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 69.182%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
leverage/logger.py	4	5	80.0%
leverage/modules/terraform.py	36	54	66.67%
<!--	Total:	44	63	69.84%	-->

Totals
Change from base Build 8847843590:	0.2%
Covered Lines:	2042
Relevant Lines:	2846

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 10565722330

Details

• 20 of 24 (83.33%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 69.151%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
leverage/logger.py	4	5	80.0%
leverage/modules/terraform.py	12	15	80.0%
<!--	Total:	20	24	83.33%	-->

Totals
Change from base Build 8847843590:	0.1%
Covered Lines:	2011
Relevant Lines:	2800

---

💛 - Coveralls

[angelofenoglio]

After consulting with @borland667 I've pushed a simplification to the originally proposed solution.

The only thing we really need to worry is to find out if we are receiving a plan file as a last argument for the apply command. And in turn, prepend or not our terraform default parameters, which basically are the references to the correct .tfvar files. Instead of parsing the entirety of the parameters, looking at the last two or so received arguments we can deduct if the last one is a positional argument or not (the plan file is the only positional parameter supported by plan). Any other errors/incompatibilities that the user may have introduced in the arguments we leave to terraform to decide.