binbashar / leverage

Binbash Leverage CLI intended to orchestrate Leverage Reference Architecture for AWS (www.binbash.co/leverage)
https://pypi.org/project/leverage/
Apache License 2.0
17 stars 2 forks source link

Project create command do not create common-variables.tf symlinks appropriately #276

Open borland667 opened 2 months ago

borland667 commented 2 months ago

Describe the Bug

When running leverage project create all the symlinks to config/common-variables.tf are followed and turned into files.

Expected Behavior

On all layers,the common-variables.tf file should be a symlink to the file that exist in config/.

Steps to Reproduce

./config/common-variables.tf
./security/us-east-1/security-base/common-variables.tf
./security/us-east-1/base-tf-backend/common-variables.tf
./management/us-east-1/security-base/common-variables.tf
./management/us-east-1/base-tf-backend/common-variables.tf
./management/global/organizations/common-variables.tf
./management/global/sso/common-variables.tf
./shared/us-east-1/security-base/common-variables.tf
./shared/us-east-1/base-network/common-variables.tf
./shared/us-east-1/base-tf-backend/common-variables.tf

Screenshots

N/A

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

Additional Context

N/A

diego-ojeda-binbash commented 1 month ago

Let's please include other updates such as: versions constraints, SNS topics redundant prefixes, toolbox image version, module versions, comment about HIPAA in security-base, and sso_role entry in account.tfvars (still needed?).