search

binbashar / leverage

Binbash Leverage CLI intended to orchestrate Leverage Reference Architecture for AWS (www.binbash.co/leverage)
https://pypi.org/project/leverage/
Apache License 2.0
17 stars 2 forks source link

[BV-599] Kubeconfig helper #281

Open Franr opened 2 months ago

Franr commented 2 months ago

What?

Why?

References

Before release

Review the checklist here

Summary by CodeRabbit

Release Notes

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11999658197

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
leverage/modules/kubectl.py 3 6 50.0%
leverage/containers/kubectl.py 41 50 82.0%
leverage/path.py 7 16 43.75%
<!-- Total: 52 73 71.23% -->
Files with Coverage Reduction New Missed Lines %
leverage/path.py 1 71.1%
leverage/modules/kubectl.py 2 72.41%
modules/kubectl.py 3 72.41%
containers/kubectl.py 10 88.89%
path.py 31 71.1%
<!-- Total: 47 -->
Totals Coverage Status
Change from base Build 11670882625: 0.4%
Covered Lines: 2518
Relevant Lines: 4032
šŸ’› - Coveralls
coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces several enhancements to the KubeCtlContainer class, adding a new ClusterInfo data class and modifying the configure method to accept it as an optional parameter. New methods for cluster scanning and discovery are implemented, improving cluster management capabilities. The auth module's file handling is updated to ensure robustness in accessing configuration files. Additionally, the kubectl module sees the introduction of a new command for cluster discovery, and the PathsHandler class is enhanced with methods for updating the current working directory and checking paths. Test coverage is expanded for these functionalities.

Changes

File Change Summary
leverage/containers/kubectl.py Added ClusterInfo data class; updated configure method; added _scan_clusters and discover methods.
leverage/modules/auth.py Updated file opening mechanism in get_profiles for improved path handling.
leverage/modules/kubectl.py Added discover command; updated shell and configure methods to include layer checks.
leverage/path.py Added update_cwd method; updated check_for_layer_location and check_for_cluster_layer methods to accept a path parameter.
pyproject.toml Added dependency simple-term-menu = "1.6.4".
tests/test_containers/test_kubectl.py Added tests for _scan_clusters and discover methods.
tests/test_modules/test_auth.py Updated open_side_effect function and assertions in tests for improved file handling.

Assessment against linked issues

Objective Addressed Explanation
Support for leverage terraform apply --all-layers command (#123) āŒ Changes do not implement the required command structure.

šŸ° In the meadow, I hop with glee,
New clusters found, oh what a spree!
With paths that lead us here and there,
Configs updated with utmost care.
Discovering layers, a joyful quest,
In the world of Kube, we are truly blessed! šŸŒ¼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

ā¤ļø Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
šŸŖ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.