Enhancement | Increase compatibility with Podman

binbashar / leverage

Binbash Leverage CLI intended to orchestrate Leverage Reference Architecture for AWS (www.binbash.co/leverage)

https://pypi.org/project/leverage/

Apache License 2.0

17 stars 2 forks source link

Closed angelofenoglio closed 1 month ago

angelofenoglio commented 2 months ago

Make the implementation more compatible with Podman.

The tool can run and perform basic operations using Podman as the container manager and not just Docker.

Users that may use Podman instead of Docker.

Leverage is able to run and execute commands on systems that use Podman instead of Docker.

angelofenoglio commented 2 months ago

As of now the only modifications we have found are necessary are:

Setting the endpoint to sh -c explicitly so that the login script is executed by a shell https://github.com/binbashar/leverage/blob/master/leverage/container.py#L408
Setting the security opts to 'label=disable' instead of 'label:disable' since Podman is not as permissive with the syntax in this argument https://github.com/binbashar/leverage/blob/master/leverage/container.py#L95