binbinhui / pe

0 stars 0 forks source link

addApp time validator #4

Open binbinhui opened 3 years ago

binbinhui commented 3 years ago

No details provided. Screenshot 2021-04-16 at 7.49.18 PM.png Need to have a time validator, to check the invalid date and time.

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

When the timing of the appointment go beyond 24hrs, it will still be saved.

Although there is a check for the appointment date's validity, there is no check of the time of the appointment which will be any digit value user inputted.

I rate this as medium because the user should avoid this kind of input. But as a appointment scheduling program, this may result in patient's appointment have not been scheduled correctly.

Command used: addApp 1 /d that /t 2021-03-31 25:00:00

image.png


[original: nus-tic4002-AY2021S2/pe-interim#143] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Invalidate is allow during the input, this one we will fix the bug, accepted

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I disagree with this change to the level low. It is critical if the patient's appointment is on an invalid date and time.