binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[Redeem][Domain] RedeemTaskEstimator injecting random UUID #14

Closed binchoo closed 2 years ago

binchoo commented 2 years ago

As-is: Line 39: why r u injecting a random UUID????? You have to pass the user UID of the given RedeemTask. https://github.com/binchoo/PaimonGanyu/blob/43fd7a63871176cf146322383ff293855a842ec0/PaimonGanyu/domain/src/main/java/org/binchoo/paimonganyu/service/redeem/RedeemTaskEstimator.java#L37-L40

To-be: Pass the UID.

binchoo commented 2 years ago

https://github.com/binchoo/PaimonGanyu/commit/d4b9fe81068316f8ef925f158e7df0f490367fd2

I accidentally changed that line.