binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[Hoyopass][Application][iKakao] make ActionParamResolver do barcode data conversion #18

Closed binchoo closed 2 years ago

binchoo commented 2 years ago

Related #17

HoyopassController receives SkillPayload.Action.Params['secure_hoyopass'] which is a JSON string containing a user's Hoyoverse auth info.

{"barcodeData": "asdf!@#$asdf!@#$asdf!@#$"}

As-is Line32: HoyopassController is responsible to extract the barcodeData field.

https://github.com/binchoo/PaimonGanyu/blob/401993f42913ac104e28f61d89c605374a20e6cc/PaimonGanyu/application/src/main/java/org/binchoo/paimonganyu/chatbot/controllers/HoyopassController.java#L30-L38

https://github.com/binchoo/PaimonGanyu/blob/401993f42913ac104e28f61d89c605374a20e6cc/PaimonGanyu/application/src/main/java/org/binchoo/paimonganyu/chatbot/controllers/HoyopassController.java#L59-L66

To-be Let me transfer its conversion responsibility to ActionParamResolver.

binchoo commented 2 years ago

https://github.com/binchoo/PaimonGanyu/blob/d63afbcd7a381bef337637ad5b827daaa523cf4f/PaimonGanyu/application/src/main/java/org/binchoo/paimonganyu/chatbot/controllers/resolvers/param/ActionParamResolver.java#L28-L77

https://github.com/binchoo/PaimonGanyu/blob/d63afbcd7a381bef337637ad5b827daaa523cf4f/PaimonGanyu/application/src/main/java/org/binchoo/paimonganyu/chatbot/controllers/HoyopassController.java#L29-L38