binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[Application] Use Spring Security for API Key validation. #30

Closed binchoo closed 1 year ago

binchoo commented 1 year ago

As-is: No API keys are required for calling the paimonganyu-skill endpoints. If an attacker who uses a fake KakaoTalk chatbot sends a request to our endpoints via the ikakao skill connectors, he may find a botUserId matching one in the PaimonGanyu system with a very low probability.

To-be: Although the probability is significantly low, I do not want to have this vulnerability affect my system. So I'll implement an API key validation using Spring Security filter chain.

binchoo commented 1 year ago

Change Impact