binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[DailyCheck][Application][HoyoApi] Fortify retry logic of HoyolabDailyCheckApi #31

Closed binchoo closed 1 year ago

binchoo commented 1 year ago

As-is: The daily check-in worker function DailyCheckWorkerFunction has no graceful error handling methods. When a UserDailyCheck is set FAILED, it depends on two subsequently scheduled DailyCheckWorkerFunction calls to successfully resolve the status to be COMPLETED. However, the interval between scheduled calls is 8-hours, which is quite long.

To-be: Setup a MaximumRetryAttemps to the DailyCheckWorkerFunction policy or a MaxReceiveCount to the queue. This may help the FAILED UserDailyCheck be resolved as COMPLETED by quicker retry attempts.

binchoo commented 1 year ago

LGTM