binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[Traveler][HoyoApi] GameRecordAPI should force all data switches on. #4

Closed binchoo closed 2 years ago

binchoo commented 2 years ago

As-is: image image

If a HoYoLab user does not turn on data switches at HoYoLab> Genshin Impact> Battle Chronicle, HoyolabGameRecordApi is not possible to fetch the user's daily note data.

To-be: When users register their Hoyopass to our system, the system should transparently set all data switches on. This policy should be notified before users scan their Hoyopass QR. image

binchoo commented 2 years ago

Change Impact

binchoo commented 2 years ago

Who is responsible to preconfigure all data switches on? -> Infra module & hoyoapi module. Never the domain module.

Because the domain module should maintain minimal information about technical aspects of APIs. Hoyoapi module and UidSearchClientAdapterclass should care about this responsibility.

Impacts of Change