Closed binchoo closed 2 years ago
Change Impact
Optional<TravelerStatus>
to filter out error responses from Hoyoverse.Who is responsible to preconfigure all data switches on? -> Infra module & hoyoapi module. Never the domain module.
Because the domain module should maintain minimal information about technical aspects of APIs. Hoyoapi module and
UidSearchClientAdapter
class should care about this responsibility.
Impacts of Change
Optional<TravelerStatus>
that helps filtering an error response from Hoyoverse.
As-is:
If a HoYoLab user does not turn on data switches at HoYoLab> Genshin Impact> Battle Chronicle, HoyolabGameRecordApi is not possible to fetch the user's daily note data.
To-be: When users register their Hoyopass to our system, the system should transparently set all data switches on. This policy should be notified before users scan their Hoyopass QR.