search

binchoo / PaimonGanyu

여행 비서 페이몬! Genshin Impact AWS workflows & KakaoTalk chatbot skills
https://pf.kakao.com/_mtPFb
GNU General Public License v3.0
7 stars 1 forks source link

[Traveler][Application] Display the sum of `resinRecoverySeconds` #6

Closed binchoo closed 2 years ago

binchoo commented 2 years ago

Steps:

  1. Execute Traveler::ListTravelerStatus block.
  2. Check resin recovery seconds,

As-is: image The resinRecoverySeconds is not useful information alone.

To-be: I define a fullResinRecoverySeconds value as (maxResin-currentResin)*480 + resinRecoverySeconds. The full recovery time of resin is more useful to genshin users.

binchoo commented 2 years ago

https://github.com/binchoo/paimonganyu/blob/c195418147fcc1bf50dc4158ad4ed55497116443/PaimonGanyu/application/src/main/java/org/binchoo/paimonganyu/chatbot/views/traveler/TravelerStatusView.java#L114 It was a simple bug in TravlerStatusView. The fullResinRecoverySeconds is actually not needed because resinRecoverySeconds has the same role.