bincode-org / bincode

A binary encoder / decoder implementation in Rust.
MIT License
2.65k stars 265 forks source link

Reverted 'static constraint on T in Vec<T> and [T; N] #663

Closed VictorKoenders closed 12 months ago

VictorKoenders commented 12 months ago

Reverted this change as there was a regression as mentioned in https://github.com/bincode-org/bincode/pull/619#pullrequestreview-1469314480

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.67% :tada:

Comparison is base (2f08107) 56.33% compared to head (7b484c1) 57.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #663 +/- ## ========================================== + Coverage 56.33% 57.01% +0.67% ========================================== Files 51 51 Lines 4317 4306 -11 ========================================== + Hits 2432 2455 +23 + Misses 1885 1851 -34 ``` | [Files Changed](https://app.codecov.io/gh/bincode-org/bincode/pull/663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org) | Coverage Δ | | |---|---|---| | [src/features/impl\_alloc.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL2ltcGxfYWxsb2MucnM=) | `61.83% <ø> (-1.08%)` | :arrow_down: | | [src/de/impls.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2RlL2ltcGxzLnJz) | `65.91% <100.00%> (+3.41%)` | :arrow_up: | | [tests/std.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-dGVzdHMvc3RkLnJz) | `97.67% <100.00%> (+0.14%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/bincode-org/bincode/pull/663/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.