bincode-org / bincode

A binary encoder / decoder implementation in Rust.
MIT License
2.63k stars 265 forks source link

Fix inconsistent naming between serde and non-serde functions #671

Closed VictorKoenders closed 10 months ago

VictorKoenders commented 10 months ago

Fixes #654

codecov[bot] commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (08556ca) 56.85% compared to head (e7db579) 56.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #671 +/- ## ========================================== + Coverage 56.85% 56.90% +0.04% ========================================== Files 51 51 Lines 4306 4304 -2 ========================================== + Hits 2448 2449 +1 + Misses 1858 1855 -3 ``` | [Files](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org) | Coverage Δ | | |---|---|---| | [src/error.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2Vycm9yLnJz) | `0.00% <ø> (ø)` | | | [src/features/serde/de\_owned.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL3NlcmRlL2RlX293bmVkLnJz) | `76.61% <100.00%> (ø)` | | | [src/features/serde/mod.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL3NlcmRlL21vZC5ycw==) | `30.43% <ø> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2xpYi5ycw==) | `16.81% <ø> (+0.03%)` | :arrow_up: | | [tests/serde.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-dGVzdHMvc2VyZGUucnM=) | `98.18% <100.00%> (+0.03%)` | :arrow_up: | | [src/features/impl\_alloc.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL2ltcGxfYWxsb2MucnM=) | `62.05% <50.00%> (+0.12%)` | :arrow_up: | | [src/features/serde/de\_borrowed.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL3NlcmRlL2RlX2JvcnJvd2VkLnJz) | `21.35% <85.71%> (+0.74%)` | :arrow_up: | | [src/features/serde/ser.rs](https://app.codecov.io/gh/bincode-org/bincode/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bincode-org#diff-c3JjL2ZlYXR1cmVzL3NlcmRlL3Nlci5ycw==) | `76.72% <80.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.