Closed mzachar closed 8 months ago
I double checked serde's implementation (which matches your implementation, so you're good) and I noticed they also implement std::cmp::Reverse<T>
. This is also a simple wrapper around T
. Would you mind adding that as well?
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
3a638a7
) 57.24% compared to head (8792100
) 57.39%.:exclamation: Current head 8792100 differs from pull request most recent head 3847e54. Consider uploading reports for the commit 3847e54 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/de/impls.rs | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't mind at all :)
Structures can clearly indicate that the value may overflow and it is intended behaviour