sdl2: remove now obsolete workaround

bincrafters / community

Central repository for issues and recipes

http://bincrafters.readthedocs.io/en/latest/

MIT License

218 stars 36 forks source link

sdl2: remove now obsolete workaround #1430

Closed Croydon closed 1 month ago

Croydon commented 3 years ago

jack can't be found anymore 👀

e.g.

https://github.com/bincrafters/community/runs/4231750091?check_suite_focus=true#step:5:2070

ericLemanissier commented 2 years ago

Shouldn't we remove sdl2 ? https://github.com/bincrafters/community/pull/1414

Croydon commented 2 years ago

I would like to keep it around for a while longer as it isn't a full replacement yet (i.e. Jack support is missing on Linux in the CCI version)

ericLemanissier commented 2 years ago

Ok, so jack cannot be found because the recipe is using the conan version of pkgconf, which does not look in the packages provided by the system. A workaround is to set environment variable PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig/, but it is obviously not portable across distros. Otherwise we should remove the use of conan's pkgconf, and use the system's pkg-config instead. (I have no idea why it passed before)