Inclusion Request: dimension3d

TheFloatingBrain commented 2 years ago

Package Details

Package Name: dimension3d
Operating Systems+versions: Linux Ubuntu 16.04, Ubuntu 18.04, Windows, macOS
Compiler support: GCC, Clang, MinGw, visual C++
Conan recipe repository: https://github.com/TheFloatingBrain/community/tree/dimension3d/recipes/dimension3d

Inclusion request

Fill all checkboxes with x if you agree with the statement or if it applies to your Conan recipe
[x] I want that my Conan recipe is getting included into the Bincrafters organisation
[x] I understand that if my request is accepted we are cloning your repository with all its history into Bincrafters, adapt some configurations and meta data if needed, and publishing it under the Bincrafters name and accounts
[x] I have used the Bincrafters templates to develop my Conan recipe - https://github.com/bincrafters/templates (referenced existing recipes in community)
[ ] My Conan recipe and all parts of it are licensed under the MIT license - https://choosealicense.com/licenses/mit/
- Bincrafters are releasing all recipes under MIT license. If you want to have your recipe within Bincrafters we kindly ask you to do the same
- it is okay if your test_package contains code from the upstream project under the upstream project's license, as long as it is clearly mentioned within the test_package files
[ ] My Conan recipe covers (at least) the latest stable version which is available for the package
[ ] I know that my Conan recipe is working on all operating system and compilers mentioned above right now
- if not: please provide here links to your CI platforms and / or build logs and describe the problems you encounter
[x] I'm willing to help to maintain the recipe even after it is included into Bincrafters

Checklist for the Bincrafters team

Ignore this if you are not part of the Bincrafters team
[ ] There is no such Conan package yet in conan-center, conan-community or Bincrafters
[ ] The project is either popular or deserves to be maintained for another good reason (we can't package every single project out there)
[ ] bincrafters-conventions reports no complains; the recipe fulfills our general quality requirements and conventions
[ ] The recipe is cloned into our organisation; CI is enabled and configurated and succeeds
[ ] There is a branch protection rule for stable/* branches, which requires a pull request with at least one approval first before things can get published
Considering granding the inclusion request author push rights to the recipe repository (there is no guarantee that everyone is getting push rights, we decide this on a case-to-case base)

Comments

Library is new but seems like it could potentially be a great introduction for 3d game programming in a simple style similar to SFML

NOTE: I edited conandata.yml for the imgui-sfml recipe to use the docking branch so it will work with dimension3d which needs it, I tested this with the code in this gist using conan and the and recipe I made.

Croydon commented 2 years ago

This inclusion request template is mostly outdated. It still exists from a time when we used individual repositories for every recipe. Now, where we have this central repository, people can just open pull requests with new recipes. Please do so.

I noticed that you haven't checked the checkbox regarding the MIT license. Please note, that all of our recipes and related files are MIT-licensed and we only accept MIT licensed contributions.

Croydon commented 2 years ago

Note: When this relies on some special version of imgui-sfml then you first need to create a pull request against this recipe to add a new version.

TheFloatingBrain commented 2 years ago

This inclusion request template is mostly outdated. It still exists from a time when we used individual repositories for every recipe. Now, where we have this central repository, people can just open pull requests with new recipes. Please do so.

Oh sorry about that haha, it just came up when I was making the issue

I noticed that you haven't checked the checkbox regarding the MIT license. Please note, that all of our recipes and related files are MIT-licensed and we only accept MIT licensed contributions.

Oh I can do that, just haven't added it yet

Note: When this relies on some special version of imgui-sfml then you first need to create a pull request against this recipe to add a new version.

Okay, I will add a configuration to conandata.yml for the imgui docking branch (I will just make the version docking).

I had a couple of questions for when I do:

How do I use the config.yml file? I tried searching the conan documentation but couldn't find it and have just been specifying version = "2.5" in conanfile.py
It seems like you dont pull repos, you pull zip archives? Any particular reason, and is it a problem if I pull the branch zip archive (e.g https://github.com/USER/REPO/archive/refs/heads/BRANCH.zip) ?
Where are you getting the checksums?

bincrafters / community