search

bincrafters / community

Central repository for issues and recipes
http://bincrafters.readthedocs.io/en/latest/
MIT License
218 stars 36 forks source link

Deprecate our own Catch2 package / helping upstream #539

Closed barcharcraz closed 5 years ago

barcharcraz commented 6 years ago

As it says in the issue title catch is on 2.4.2 now.

Also catch has an upstream conanfile now, which may be better to use than this one (for one it actually installs using cmake.

Croydon commented 6 years ago

If they have official Conan support then our package is becoming obsolete and we should help them instead to get it into conan-center.

Croydon commented 6 years ago

Actually: https://github.com/catchorg/Catch2/pull/943

uilianries commented 6 years ago

oh man, just 1 year ago ... :birthday:

I need to update that PR!

uilianries commented 6 years ago

Related PR: https://github.com/catchorg/Catch2/pull/1443

uilianries commented 5 years ago

Let's wait for the next Catch2 release before to deprecate Bincrafters support for Catch2. Also we should update the README file and add an warning message.

Croydon commented 5 years ago

Catch2 has now own uploads on Bintray. We can help them now getting it into conan-center (if not already done @uilianries? 😄 )

Croydon commented 5 years ago

Todo

danimtb commented 5 years ago

Hi guys!

I have just included official Catch2 into Conan Center: https://bintray.com/catchorg/Catch2/Catch2%3Acatchorg

Next step would be deprecating the bincrafters recipe with a message. We already did this with PEGTL: https://bintray.com/bincrafters/public-conan/pegtl%3Abincrafters

Thanks!

uilianries commented 5 years ago

Thanks @danimtb !

uilianries commented 5 years ago

Ops! https://travis-ci.com/bincrafters/conan-catch2/builds/93495573#L927

Looks like alias is not working well

uilianries commented 5 years ago

I think we are good to go