bincrafters / community

Central repository for issues and recipes
http://bincrafters.readthedocs.io/en/latest/
MIT License
218 stars 36 forks source link

[libcurl] fails to build on Windows #809

Closed acgetchell closed 5 years ago

acgetchell commented 5 years ago

Package and Environment Details (include every applicable attribute)

Conan profile (output of conan profile show default or conan profile show <profile> if custom profile is in use)

Configuration for profile cdt: [settings] os=Windows os_build=Windows arch=x86_64 arch_build=x86_64 compiler=clang compiler.version=8 compiler.libcxx=libstdc++ build_type=Release [options] [build_requires] [env] CONAN_CMAKE_GENERATOR=Ninja

https://ci.appveyor.com/project/acgetchell/cdt-plusplus/build/job/os83jt68q1956jho?fullLog=true#L4807

Steps to reproduce (Include if Applicable)

Use a package like date/2.4.1@bincrafters/stable that requires libcurl. The build process invokes autoconf, which I installed using msys2:

https://ci.appveyor.com/project/acgetchell/cdt-plusplus/build/job/dww1wr6j9q3ow99g?fullLog=true#L66

But this recipe doesn't seem to recognize it.

Logs (Include/Attach if Applicable)

https://ci.appveyor.com/project/acgetchell/cdt-plusplus/build/job/os83jt68q1956jho?fullLog=true#L22030

acgetchell commented 5 years ago

From a discussion on the Conan channel in Slack, the recipe should invoke tools.run_in_windows_bash().

SSE4 commented 5 years ago

@acgetchell applied, please give an another try: https://github.com/bincrafters/conan-libcurl/commit/93b730b770097d96e6edbe8b03236863403f05d4

acgetchell commented 5 years ago

autoconf 2.69-5 is installed from msys2:

https://ci.appveyor.com/project/acgetchell/cdt-plusplus/build/job/j0qdhgc5t1ywv2ye?fullLog=true#L65

But not detected:

https://ci.appveyor.com/project/acgetchell/cdt-plusplus/build/job/j0qdhgc5t1ywv2ye?fullLog=true#L22497

SSE4 commented 5 years ago

@acgetchell it's using Git Bash: run_in_windows_bash: "C:\Program Files\Git\usr\bin\bash.exe" this is not intended, I'll take a look

SSE4 commented 5 years ago

@acgetchell meanwhile, may you try to set CONAN_BASH_PATH environment variable to the right bash instance? it seems like on appveyor, Git prepends MSYS2 in PATH, so conan auto-detects wrong one

SSE4 commented 5 years ago

I think we have got further with this one, and have https://github.com/conan-community/community/issues/222 to track it, so closing