search

binder-examples / r

Using R with Jupyter / RStudio on Binder
BSD 3-Clause "New" or "Revised" License
222 stars 278 forks source link

shiny binder link is off #13

Closed choldgraf closed 5 years ago

choldgraf commented 6 years ago

Not sure what exactly, but here's what I see:

image

The link has resolved to:

https://hub.mybinder.org/hub/bus-dashboard/?token=<MYTOKEN>

which seems wrong, since there is no pod URL in there...

Here's what the binder link in the readme points to:

https://mybinder.org/v2/gh/binder-examples/r/master?urlpath=shiny/bus-dashboard

If I do not include urlPath in the url, then it directs me to the correct URL. I can also confirm that urlPath still works fine on the jupyterlab demo repository.

cc @betatim !

choldgraf commented 6 years ago

Also, note that this actually happens after the repository loads, after redirection from /shiny/bus-dashboard

betatim commented 6 years ago

Updated the link in the README this morning.

It has to be http://beta.mybinder.org/v2/gh/binder-examples/r/master?urlpath=shiny/bus-dashboard/ and it was http://beta.mybinder.org/v2/gh/binder-examples/r/master?urlpath=shiny/bus-dashboard which fails (trailing / missing).

choldgraf commented 6 years ago

ah hmmm, good to know...is that a bug we need to squash somewhere?

betatim commented 6 years ago

If it is a bug then it is in nbserverproxy, but I am not sure if it is a bug or expected behaviour. From a usability/user point of view I find it annoying.

mrjoh3 commented 5 years ago

I suspect I am having a similar issue. I just can't get my app to load. The build seems to work but the URL does not. I have tried numerous variations but nothing works. It is a fairly simple shiny app and I have tried it both in the repo root directory and in an app/ folder. My app can be found here:

https://github.com/mrjoh3/georefr

I am setting the urlpath as app and have tried app/ and shiny/app/. Currently the URL returned is

https://mybinder.org/v2/gh/mrjoh3/georefr/master?urlpath=app

when the app launches this changes to:

https://hub.mybinder.org/user/mrjoh3-georefr-p6bl27ag/app

the former tries to load but fails both end in a 404 error. Any suggestions or advice would be appreciated.

betatim commented 5 years ago

For me https://mybinder.org/v2/gh/mrjoh3/georefr/master?urlpath=shiny/app/ works. The important part is the trailing slash, without it it doesn't work.

mrjoh3 commented 5 years ago

thanks for the quick response, I keep getting redirected from that URL to versions of:

https://hub.mybinder.org/user/mrjoh3-georefr-pz6urypy/shiny/app/?token=eq6qM5wmR6C-A8FXZKMdhQ

I might try this at home to make sure it is not some weird network issue on my end

choldgraf commented 5 years ago

@mrjoh3 did you figure this one out? wanna make sure this isn't a bug on binderhub's end

mrjoh3 commented 5 years ago

no I am still getting the same problem the server was loading but ending in an error message (copied below). I then tried rebuilding once more and have included a screenshot of the setup below

An error has occurred

The application failed to start.

The application exited during initialization.

[image: Screenshot from 2018-11-30 20-45-13.png]

On Fri, 30 Nov 2018 at 11:30, Chris Holdgraf notifications@github.com wrote:

@mrjoh3 https://github.com/mrjoh3 did you figure this one out? wanna make sure this isn't a bug on binderhub's end

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/binder-examples/r/issues/13#issuecomment-443045688, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1TAeDmNadMzoR4iiWONRnqopEH4euOks5u0HwUgaJpZM4UV303 .

betatim commented 5 years ago

I get that error as well (application failed to start), this is a problem with the Shiny app though I think.

mrjoh3 commented 5 years ago

I have add some extra dependant packages just in case. But the app works fine locally and on shinyapps.io

https://mrjoh3.shinyapps.io/georefr/

On Fri., 30 Nov. 2018, 21:01 Tim Head <notifications@github.com wrote:

I get that error as well (application failed to start), this is a problem with the Shiny app though I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/binder-examples/r/issues/13#issuecomment-443153294, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1TATVG2ceglXbcc--0UuE5jQHRNeEEks5u0QHmgaJpZM4UV303 .

MarijaStanojcic commented 5 years ago

I see this is still open, and I am encountering the same issue. My app works fine locally and on shinyapps.io, but I'm also getting the same error as @mrjoh3. Any advice?

betatim commented 5 years ago

Hi there 👋!

Can we move this discussion to http://discourse.jupyter.org/ (where most of the people who hang out here also hang out, as well as more people). We are trying to streamline the different discussion places and want to use the issues on GitHub repos for technical discussions on how to change the contents of the repo. More general discussions should go to discourse so that they are easier to find, better indexed by google and generally more accessible than being hidden in the bowls of a GitHub repository ;)

Thanks!