search

binder-examples / r

Using R with Jupyter / RStudio on Binder
BSD 3-Clause "New" or "Revised" License
222 stars 278 forks source link

Added explanation to index.ipynb #26

Closed pablobernabeu closed 4 years ago

pablobernabeu commented 4 years ago

Added explanation to index.ipynb: 'File serving the purpose of creating a Binder repo (https://github.com/binder-examples/r).'

choldgraf commented 4 years ago

Hey @pablobernabeu - thanks for opening the PR. Could you explain the confusion that you're trying to clear up with this PR? Thanks

pablobernabeu commented 4 years ago

Hi @choldgraf - Of course. The note explains the reason why the 'index.ipynb' file must be present in the repository. In other words, if this file is removed, the repo can no longer be deployed to Binder (at least the RStudio and the Shiny environments cannot, as far as I experienced). I once added this to the readme, too, but I see it's been removed since.

choldgraf commented 4 years ago

Hmmm - that actually feels like a bug though, instead of expected behavior. The index.ipynb file shouldn't be needed to run a shiny dashboard. What was the behavior you experienced when removing index.ipynb?

pablobernabeu commented 4 years ago

Hi @choldgraf,

I've just double-checked this, and found that both RStudio and Shiny can be deployed even without having the index.ipynb file. Great to know! Thanks, and sorry for the confusion.

All the best

choldgraf commented 4 years ago

wohoo - glad it worked :-)