Hacky rewrite of the plugin to fix issues with output directory and embedding

bindestriche / srt_fix

yt-autosub-srt-fix a yt-dlp plugin to fix double lines of youtube subtitles converted to srt via ffmpeg

The Unlicense

22 stars 5 forks source link

Hacky rewrite of the plugin to fix issues with output directory and embedding #4

Closed JanX2 closed 10 months ago

JanX2 commented 1 year ago

Please review and change anything that doesn’t feel right or not Pythonic. I’m not at all experienced in writing Python. Assume I hav no idea what I’m doing. Though, at least currently, my rewrite works for me.

Thank you for handing me a solid foundation!

bindestriche commented 1 year ago

I am glad this is usefull to someone. I will look at it as soon as I can find the time (in 3 weeks the earliest)

JanX2 commented 11 months ago

@bindestriche Thanks! I’m glad you are interested. :)

JanX2 commented 10 months ago

@bindestriche Any news regarding my approach?

bindestriche commented 10 months ago

Any news regarding my approach? I just merged it hoping for the best.