search

bineanzhou / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

AssistedInject should blow up if interceptors apply #248

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The fact that interception doesn't apply to AssistedInject-created classes
violates the principal of least astonishment. At a minimum, we should blow
up if the user's code would have had interception but won't (ie. if methods
qualify for the interceptors' matchers).

Original issue reported on code.google.com by limpbizkit on 16 Sep 2008 at 8:08

GoogleCodeExporter commented 9 years ago 
I had a brief review of the AssistedInject code... is there a reason why we can 
not
create a proxy for the given implementationType (as far as it is not final) 
which 
invokes all applyable interceptors and acts as an delegate?

Original comment by sven.lin...@gmail.com on 17 Sep 2008 at 12:19

GoogleCodeExporter commented 9 years ago 
This has been a pretty big issue for us. If what Sven mentions is possible, it 
would
be a huge help. If you can put together some ideas and maybe an outline of how 
to go
about it we can make an attempt at a patch for this feature.

Original comment by erikcell...@gmail.com on 15 Oct 2008 at 8:45

GoogleCodeExporter commented 9 years ago 
We'll fix this with issue 131.

Original comment by limpbizkit on 4 Nov 2008 at 6:00