search

binggg / mrn

Material React Native (MRN) - A Material Design style React Native component library.
http://mrn.js.org
1.73k stars 109 forks source link

Button tap doesn't bounce back its state #18

Open bozzmob opened 8 years ago

bozzmob commented 8 years ago

Let me explain this behaviour. This is in reference to #9 and #10. But, clearly this issue is with the button component. When I click on the button, it doesn't bounce back to released state. It is stuck in pressed state.

Phone - Samsung Galaxy S4 OS version - 5.0.1 and 5.1.1 (Tested on both)

I will look into this as well, will pull a PR soon. Just wrote it here so as to keep track of things.

Ehesp commented 8 years ago

Are you sure it's the button? If you go to the demo, with checkbox and hold down on the "box" item, the background effect is there... so it looks like it's more the ripple?

image

bozzmob commented 8 years ago

@Ehesp Yes, I am talking about the button. The same issue is there on buttons as well.

Ehesp commented 8 years ago

I think I found out why this happens, if you hold down the item, then scroll your view, let go the "touch up" trigger seems like it's not being triggered.

Ehesp commented 8 years ago

Hmm saying that, it doesn't happen on the latest demo APK for me... Unless something has changed?