binggg / mrn

Material React Native (MRN) - A Material Design style React Native component library.
http://mrn.js.org
1.73k stars 109 forks source link

Add ability to hide Toolbar navIcon #19

Open mrcasals opened 8 years ago

mrcasals commented 8 years ago

PR #14 added the ability to overwrite the default Toolbar navIconName. I want to use a Toolbar without any navIcon, so I was thinking that the default behaviour could be no icon, and if the user wanted an icon then they would need to explicitly name it:

Toolbar without an icon:

        <Toolbar
          actions={this.props.actions}
          primary="paperLightBlue"
          title={this.props.title}
        />

Toolbar with an icon:

        <Toolbar
          navIconName="menu"
          actions={this.props.actions}
          primary="paperLightBlue"
          title={this.props.title}
        />

What do you think?

binggg commented 8 years ago

Yes, You are right. It was my original intention. I forget it.