search

binggg / mrn

Material React Native (MRN) - A Material Design style React Native component library.
http://mrn.js.org
1.73k stars 109 forks source link

Optional menu button #20

Open carbureted opened 8 years ago

carbureted commented 8 years ago

As per #19, this only creates a menu button if navIconName is defined.

However, I noticed a bug where you don't get an icon if the navIconName is named anything other than "menu", which doesn't seem to be as intended. I can fix that, but it might be best done in a different pull request since it could break the current examples.

Ehesp commented 8 years ago

This works, the icon type issue was fixed in https://github.com/binggg/mrn/commit/71e23771b49b22d26a61e64cfd9ab5acf4ee6fb0#diff-39f15dcb5540310cc645f61cf2724af7R70, so @binggg will need to sort a merge conflict out here.

carbureted commented 8 years ago

There shouldn't be a merge conflict, as best I can tell. The issue I mentioned above is that I misread the purpose of navIconName - I thought it was arbitrary, so I passed in "foo" and it ended up being predictably broken :)

mrcasals commented 8 years ago

:+1:

Ehesp commented 8 years ago

I added this over at https://github.com/material-react-native/mrn/blob/master/lib/Toolbar.js