search

bingnz / cucumber-teamcity-formatter

Formatter for cucumber-js to write test output to the console in a format parsable by TeamCity.
MIT License
4 stars 3 forks source link

[WIP] Show skipped tests as ignored in team city #3

Closed kevinkuszyk closed 6 years ago

kevinkuszyk commented 6 years ago

This is the PR for #2.

Whilst the tests pass, I'm not 100% this code works - when I added it to one of our projects here, scenarios which are skipped are showing as passed in team city.

When I logged out the scenario status they are coming through as passed instead of skipped. I'm not sure if the problem is:

  1. Something wrong in my assumptions for this code.
  2. Something wrong in the wiring in our solution (we have protractor and protractor-cucumber-framework in the mix).
  3. Something wrong in cucumber.

Feel free to merge, but I'd like to keep this as WIP until I've had a change to investigate further. Unfortunately I don't when that will be as I need to get on and ship some features to my customer.

bingnz commented 6 years ago

This looks good to me; I'm happy to merge once the codeclimate issue is fixed (I think extracting some of the logic into a separate function will make it happy).

kevinkuszyk commented 6 years ago

@bingnz I just pushed an update which fixes that codeclimate issue.