bingo235 / rush-osd-development

Automatically exported from code.google.com/p/rush-osd-development
0 stars 0 forks source link

Backport two bugfixes (MSP RSSI & baseflight fix) #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I fixed two issues I encountered while using rush-osd with baseflight, a 32bit 
port of MultiWii. One of them is related to the USE_BOXNAMES option, which is 
still a compile-time option in the current HG revision. The other is related to 
the range of RSSI sent via MSP. 

Both fixes are very small, it would be nice if you could review & apply them to 
the main tree:

MSP RSSI fix: 
https://github.com/the-kenny/rush-osd/commit/44fd9716603a53057e2dc18fd25a5b9fc99
1062e
MSP sends rssi as a value between 0 and 1023. rush-osd's rssi calibration 
assumes it max. value is 255 (or 254, don't remember). This fixes the 
calibration issue.

USE_BOXNAMES fix: 
https://github.com/the-kenny/rush-osd/commit/7fa51bbad6d6a27e97654f420e874d995fb
a1731

Original issue reported on code.google.com by ulrich.moritz on 5 Dec 2013 at 11:47

GoogleCodeExporter commented 8 years ago
thanks for your report. 
Issue with MW_RSSI is already fixed for some time now on the repo, also in 
GUI´s Simulator (GUI fix not online yet).
I will take a look at BOXNAMES issue, in fact we only use BOXNAMES because of 
the GUI compatibility with current programming, and because some pilots out 
there are still using old MW versions (prior to BOXID´s implementation).

Original comment by katawentos on 8 Dec 2013 at 5:49

GoogleCodeExporter commented 8 years ago
BOXNAMES is a simple issue: It's a run-time setting, but the main loop accesses 
it as a compile-time value. Looks like someone forgot to change the lines when 
the run-time settings were introduced.

Original comment by ulrich.moritz on 9 Dec 2013 at 2:09

GoogleCodeExporter commented 8 years ago
Yep, Thanks.

Original comment by katawentos on 9 Dec 2013 at 5:57