search

bingothon / bingothon-layouts

On-Stream layouts for Bingothon
MIT License
0 stars 4 forks source link

Add Prettier and refactor ESLint configuration #86

Closed timoschwarzer closed 1 year ago

timoschwarzer commented 2 years ago

Usage: npm run lint (npm run lint -- --fix to fix).

All files have been reformatted to match the Prettier rules.

Closes #82

lepelog commented 2 years ago

I'm not sure if this is a good idea, we need to coordinate that internally since we sometimes share code with our restream layouts, and it would suck if cherry picking stops working because of this.

Also, the schema/*.d.ts files are autogenerated and should not be formatted

Not sure if adding github actions is useful, since we always push to master anyways, seems like a waste of resources

timoschwarzer commented 2 years ago

Not sure if adding github actions is useful, since we always push to master anyways, seems like a waste of resources

For ori-rando CI pipelines were very useful to detect errors early, especially ones that occurr because of missing/uncommitted files or similar since it always does a clean build in CI.

timoschwarzer commented 2 years ago

Also, the schema/*.d.ts files are autogenerated and should not be formatted

https://github.com/bingothon/bingothon-layouts/pull/86/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R38

They aren't formatted.

Floha258 commented 1 year ago

I finally got around to look at it. The config looks good, however when trying to run it, I'm getting the following error (the other errors are the same problem, just in other files)

C:\Users\Floha\nodecg\bundles\bingothon-layouts\src\graphics\video-player\main.vue
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src\graphics\video-player\main.vue.
The extension for the file (.vue) is non-standard. You should add "parserOptions.extraFileExtensions" to your config

✖ 97 problems (97 errors, 0 warnings)

ERROR: "lint:browser" exited with 1.

The extension scripts runs without any problems.

timoschwarzer commented 1 year ago

I'll take a look at it, can't promise it'll be before next year though 😅

Floha258 commented 1 year ago

@timoschwarzer Would you have time soon to look into this? Cause none of us, was able to really work it out