bingryan / obsidian-ibook-plugin

export mac ibook annotations/hightlights to obsidian vault
MIT License
69 stars 2 forks source link

Deleted books still displayed in ibook export options #48

Open galachus opened 1 year ago

galachus commented 1 year ago

Deleted books (from Apple Books) are still displayed in book export options. Reinstalling ibook plugin, logging out of iCloud, and restarting the workstation does not resolve the issue. Is there a way to clear the cache or folder?

bingryan commented 1 year ago

ibook: the book is deleted, but the annotations in the ibook will not be deleted

bingryan commented 1 year ago

Can you describe the feature you want?

galachus commented 1 year ago

When running the ibook export command, ibook is listing books that are not in my library (they were deleted a long time ago). Where is it getting the list? No feature is needed - only a fix.

bingryan commented 1 year ago

When running the ibook export command, ibook is listing books that are not in my library (they were deleted a long time ago). Where is it getting the list? No feature is needed - only a fix.

from ibook local sqlite db

bingryan commented 1 year ago

for #40, some people also want to keep this historical information 🤣

galachus commented 1 year ago

40 is for delta sync of annotations of deleted books. Other people want to keep the annotations. I have no annotations or books in my Books app library. Everything has been deleted. But, ibook plugin shows previously deleted pdfs and book samples. It's a different issue.

bingryan commented 1 year ago

maybe you can export-single-book-by-search, not export all .

galachus commented 1 year ago

I'm already using it. It lists 20 books I don't have in my library. 🤷‍♂️

bingryan commented 1 year ago

If you really don't want to list books that are not on your library, I will add toggle setting to filter deleted book.

galachus commented 1 year ago

A toggle to hide deleted books would be helpful. Many people download many book samples and pdfs only to view them temporarily in Apple Books.

Thank you for the plugin and your support. 👍

bingryan commented 1 year ago

I reorganized the logic, you should delete the records on icloud, but not delete the local records. when you delete book, you should choice "delete all"

bingryan commented 1 year ago

The current logic is based on the ibook library, if you delete book, you will choice delete all(icloud / local), the book info will not at library(and local sqlite db will delete this record)

bingryan commented 1 year ago

the version of my ibook is 5.1 (5743), I don't know if yours is the same version

jun6lee commented 1 year ago

I think it's not really something in the purview of the plugin, although the toggle would be a nice to have. If the sql file contains deleted books and highlights, this might be something Apple simply wants to hold on to.

They have the same logic when it comes to apps purchased on the App Store, you can hide them, but never really delete them from your iCloud account history.