search

bingsen0806 / pe

0 stars 0 forks source link

Able to edit person to have same email #5

Open bingsen0806 opened 2 years ago

bingsen0806 commented 2 years ago

Reproduce:

  1. Already have person A with email test@test
  2. Edit person B to have email Test@test

case_sense.PNG

As per module website, email comparison should not be case sensitive as per real world

However, it can be seen that I am able to edit person B to have same email as person A. I placed this as functionality instead of feature flaw because it's a mismatch with UG, which states that I cannot edit person into having the same name or email

image.png

nus-pe-script commented 2 years ago

Team's Response

Reason

In terms of user experience in the real world specifically under the request for comments (RFC) publication. According to RFC 5321 as shown below, the local part parts of the email can be treated as both case sensitive and case insenstitive. Hence the local part of the email can indeed be case insenstive.

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree with the tester that the local part of email could be case sensitive. It is partly my fault for not providing more test cases.

However, it is clear from my title of bug report "Able to edit person to have the same email" and my description of bug report that my bug report is referring to the fact that the app's duplicate detection mechanism does not conform with expectations of the real world.

In the real world, local parts of email may be case-sensitive or case-insensitive, but domain parts of email are always case-insensitive. This is shown in this stackoverflow answer, which screenshot is also provided below:

image.png

With that being said, the app is unable to detect that I am editing two employees to have the same email, despite that being mentioned in their UG

image.png

image.png

image.png

While I do not explicitly provide this test case during the PE due to time constraint, I believe that the title of the bug report and the description is specifically referring the duplicate email detection functionality of the app, and should be specific enough for the developer to identify flaws in their app.

As what prof Damith said in this forum post, bug reports have achieved its main purpose if it is good enough for the developers to detect their error. In this case, I believe that my bug report title and description is specific enough to achieve that purpose.

image.png