search

bingsen0806 / pe

0 stars 0 forks source link

Inaccurate message when marking tasks as done, or unmarking task #6

Open bingsen0806 opened 2 years ago

bingsen0806 commented 2 years ago

image.png

Start with the screenshot above, we see that 1st task is already done and 2nd task is already not done

If i do "markTask 1" or "unmarkTask 2"

I should expect the system to tell me that task 1 is already marked as done, and task 2 already marked as undone, but instead the system keeps sending success message.

soc-se-bot commented 2 years ago

Team's Response

Reason

The markTask and unmarkTask command is indeed working as intended. This is evident from the UG where we have clearly stated that "Marking a marked task (i.e., that is already set as done) will not change its physical state." which is shown below, similarly for unmarkTask. As such when the team was implenting this feature, we felt that there was no need to throw an error message as marking an already marked task does not cause any major issues.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do agree partly with the developers that "The markTask and unmarkTask command is indeed working as intended", as what is specified in their User Guide, this is the reason why I did not report the bug as a functionality bug (bugs that are not working as intended according to UG), but instead reporting this bug as a feature flaw.

I am reporting that this "intended behavior" of showing success messages repeatedly is a feature flaw (i.e. the developer team should not design the app to show success messages repeatedly). As per my original report, I expect messages such as "this task is already marked as done" to be shown, instead of "Task is set as done".

My expectation is reasonable because many real world systems behave this way.

For example, when you first login to any/most apps, it is expected to show "Successfully logged in" message. However, after you login, either the login button should change to "you are already logged in", or when you click on login button, it should show you "You are already logged in" instead of keep letting you log in again and saying "logged in successfully". Another example is that when submitting forms that only allows one submission. If the user is able to click the "submit" button repeatedly (simlar to how this ManageEZPZ app also allows users to input markTask and unmarkTask commands repeatedly), then upon the second "submit" click and beyond, most systems know that this form is already submitted and will show something like "You have already submitted this form. You are only allowed to submit once", instead of repeatedly showing "Form submitted successfully"

According to the module website, unspecific error messages are considered as low level feature flaw (screenshot below). I believe that such correct but not specific enough success respond message are considered low severity feature flaw as well.

image.png

Furthermore, the developer's screenshot of UG does not justify why this is not a feature flaw. The screenshot shows that "marking a marked task that is already marked does not change the physical state)". Physical state of the task has nothing to do with the bug report. When a user tries to mark an already marked task, consider the following two cases:

  1. case 1: physical state is marked->marked (no change in state), but success respond message (or error message, either is ok) shows "Task already marked"
  2. case 2: physical state is marked->marked (also no change in state), but success respond message shows "Task marked as done".

Both case 1 and case 2 does not change the state, but case 2 has unspecific and confusing message to the user, hence the developer's response of screenshotting their UG does not justify their defense against the bug report.

I also agree with the developers that "marking an already marked task does not cause any major issues". That is why this bug report is low severity but should not be rejected. Despite not causing major issues, their is still minor issues caused, and unspecific messages are considered low level bugs as per module website screenshot shown above. If this feature flaw actually requires high effort to be corrected, with the limited time nature of this module, it may be considered not in scope. However, this feature flaw can be fixed very easily with small changes to respond messages and an additional check to see if the task is already marked/unmarked, hence I personally do not think that is is justified for this issue to not be a bug.