search

bingsen0806 / pe

0 stars 0 forks source link

App restricts events to be one day #7

Open bingsen0806 opened 2 years ago

bingsen0806 commented 2 years ago

Obviously in many real world scenarios, events are not one day (e.g. being in charge of team bonding event in company).

The app does not allow this

soc-pe-bot commented 2 years ago

Team's Response

Reason

This bug can be counted as a duplicate because it is the same exact bugs found in #203. Hence solving #203 would solve this as well.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Not allowed to add an event that starts at 2359 and ends in the next day

addEvent desc/Go party at zouk!!! at/2022-04-16 2359 0640

Expected:

  • Should be allowed to add an event that rolls over to the next day

Actual:

  • The event is rejected because ENDTIME is treated as the same day!

image.png

[original: nus-cs2103-AY2122S2/pe-interim#370] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Reason

Although we acknowledge that there are some events that would last longer then a day, the intended feature of this addEvent command was that Managers/Supervisors to only add daily tasks (that can be complete within the working hours). However, we have also noticed that it was our fault that we only stated in the UG/DG that START_TIME should be strictly earlier then the END_TIME and we did not consider this case regarding the valid time of more then 1 day. On top that, our UG/DG also did not mentioned that the times of an event could be more then a day but through the UG parameters such as this addEvent where only ONE date is taken in as the date parameter, we feel that the readers could infer that an event should be no longer then a day. As such, our team feels like this should be a DocumentationBug where there were details missing from the UG.

Furthermore a low severity bug is defined as a flaw that is unlikely to affect normal operations. As mentioned above, since the intended feature of the addEvent command was for daily tasks this bug should be low severity because it does not affect normal operations and only comes out in very rare situations where tasks needs takes longer then a day to be completed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: I do not agree that this is a documentation bug. An issue is a documentation bug if it is the documentation that should be changed, and is a feature flaw if it is the feature design that needs to be changed.

In this case, the feature design needs to be changed, not the documentation.

In fact, the developers' own explanation justifies that the bug is not a documentation bug, as quoted below:

only ONE date is taken in as the date parameter, we feel that the readers could infer that an event should be no longer then a day

Indeed, I agree with the developers that as a user I am able to infer that their app does not allow event inputs that spans across day. This is the exact reason why it should not be a documentation bug, because adding extra lines such as "Events must be within the same day" in the User Guide does not add value as users can already infer from it. It is not the documentation that should be changed, but rather the feature that needs changing.

Due to the same reason, adding "Events must be within the same day" after "_START_TIME should be strictly earlier then the ENDTIME" (quoted from developer response) in the UG/DG is not what is important.

I have justified that why this is not a documentation bug above, and below is the justification on why it should be a feature flaw:

Below is the screenshot of the target users and intended values added to the target users, from the UG:

image.png

As expected, managers should be able to assign company-related tasks to their subordinates. Participating in company-organized events is obviously a task for its employees (e.g. an employee should participate in the hackathon organized by his/her company for school children, to facilitate the flow of the hackathon).

Real world examples:

  1. Some Shoppee employees have to be assigned this task by their managers to facilitate the 3-day Shoppee Hackathon.
  2. A robotics company employee have to be assigned task by his/her manager to conduct this 3-day promotional robotics workshop for kids.
  3. A R&D researcher from a company assigned a task by his manager to attend a 3-day conference.

The examples above are clearly within the definition/scope of the "should be able to assign tasks to subordinates". Not allowing tasks with multiple-day events impacts the usability of this app.

With that being said, I do agree with the developer that this bug should be low severity.