search

binhex / arch-minecraftserver

Docker build script for Arch Linux base with Minecraft Java server
GNU General Public License v3.0
18 stars 27 forks source link

[Feature Request] Toggle Download of Vanilla Minecraft #7

Closed Unkn0wnCreator closed 3 years ago

Unkn0wnCreator commented 3 years ago

hi,

i would love to see an toggle like true/false for turning off Downloading latest Vanilla version.

i use mostly Papermc and waterfall for bungeecord and i dont need the vanilla jar.

Like this its waste of space. When i run like 10 servers (game servers) and every server has like 40mb - 50mb wasted space it would use 400mb - 500mb of my harddrive for nothing

binhex commented 3 years ago

if you run 10 servers then due to shared docker layers you will use only 40MB not your suggested of 400-500.

Unkn0wnCreator commented 3 years ago

thats might be true but im using Unraid and save the Server files in one Share so in this case docker is not utilising this system.

Unkn0wnCreator commented 3 years ago

and a little not important thing

when running Bungeecord or else it wont boot until i added eula.txt and restart the container.

binhex commented 3 years ago

ok ive taken a look at this and i have now put in a check, if the jar is custom (as defined by CUSTOM_JAR_PATH) then it will skip the file copy, i have also enhanced the generation of the eula to be generated next to the jar file, even for custom paths, please test this by specifying the 'test' tagged image.

Unkn0wnCreator commented 3 years ago

after testing with two servers (one Bungee, one papermc) i can say, it seems to be working verry well.

Thank you!

you can close this issue if there are no more questions

binhex commented 3 years ago

after testing with two servers (one Bungee, one papermc) i can say, it seems to be working verry well.

Thank you!

you can close this issue if there are no more questions

excellent! thanks for letting me know, i will tag this as 'latest' shortly, so please switch back in an hour from now.