search

binhonglee / coco

Code coverage for Nim lang (CLI + library)
MIT License
46 stars 3 forks source link

[minor] wrong path in '[OK] Cleanup custom locations' : #10

Open timotheecour opened 5 years ago

timotheecour commented 5 years ago

[OK] Cleanup custom locations: /Users/.choosenim/toolchains/nim-0.19.0/lib/system.nim: No such file or directory /Users/.choosenim/toolchains/nim-0.19.0/lib/system.nim: No such file or directory /Users/.choosenim/toolchains/nim-0.19.0/lib/system.nim: No such file or directory

should be: /Users/username/.choosenim/toolchains/nim-0.19.0/lib/system.nim etc

samuelroy commented 5 years ago

I have no idea where this comes from. I would need some help here as I'm new to Nim.

By the way, the "Cleanup custom locations" is a simple unit test on the proc reset_coverage. It creates folders and a .info file then call reset_coverage with some parameters.

timotheecour commented 5 years ago

I have no idea where this comes from. I would need some help here as I'm new to Nim.

not sure either on quick inspection; but using doAssert instead of silently ignoring error codes via discard (see https://github.com/samuelroy/coco/issues/11) would give a stacktrace and should reveal where it gets generated

timotheecour commented 5 years ago

(btw, hope you don't mind the issues I'm reporting; I think it's an awesome tool, I'm only trying to help by pointing out usability issues)

samuelroy commented 5 years ago

Not at all, thanks for your feedback, it's really appreciated. I'm exploring Nim through this project and I want to see if it's worth investing my time and my team in it.

timotheecour commented 5 years ago

I want to see if it's worth investing my time and my team in it.

I really hope it'll turn out positive ... happy to help, and the forum is usually a friendly and efficient place to ask questions (so is nim irc/gitter channel)