Open binhussen opened 1 year ago
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Good job with your script.js function added :+1:
[ ] List of GitHub usernames assigned to Team member 1, Team member 2, Team member 3. Each member should have tasks assigned to him based on and specified by this template
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thanks, @GzimAsani for your feedback, we will modify it
In this PR we have Prepared the kanban board
here is prepared kanban board
Hi @binhussen, @peterboro, and @dlwub,
Great work on making the changes requested by a previous reviewer π You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
[ ] Nice job assigning the group members each tasks as mentioned earlier :rocket:
Check the comments under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this PR we have Prepared the kanban board
here is prepared kanban board
Hi Team,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
pt
after the points number to match the given template for the Kanban board.Your template | Microverse template |
---|---|
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you @gemmen29 for your feedback we will modify it.
Prepare Kanban board
In this PR we have Prepared the kanban board
Group Members
here is prepared kanban board