search

binji / wasm-e2e

Temporary scaffolding for running WebAssembly end-to-end, from C++ to browsers.
Apache License 2.0
23 stars 4 forks source link

Examples fail with ReferenceError: _WASMEXP_ is not defined #22

Open ossy-szeged opened 8 years ago

ossy-szeged commented 8 years ago

$ scripts/run.py test/fizzbuzz.c /home/oszi/wasm/wasm-e2e/test/wasm.js:46: ReferenceError: WASMEXP is not defined m = WASMEXP.instantiateModule(readbuffer(arguments[0]), ffi); ^ ReferenceError: WASMEXP is not defined at /home/oszi/wasm/wasm-e2e/test/wasm.js:46:5

titzer commented 8 years ago

In V8 we've recently renamed the WASMEXP object to simply "Wasm".

titzer commented 8 years ago

This is already updated in sexpr-wasm-prototype, so maybe just wasm-e2e needs to be updated.

ossy-szeged commented 8 years ago

Ah, wasm-e2e uses fixed binaryen and sexpr-wasm-prototype revision with trunk v8. It isn't good at all. I tried to use trunk binaryen and sexpr-wasm-prototype too, but didn't manage to get a working version.

Is it documented anywhere which revisions of these tools are compatible with each other?

dschuff commented 8 years ago

wasm-e2e hasn't really been updated in a while. If you want to test integration between v8, sexpr-wasm, binaryen, emscripten, and LLVM, it might be easier to try the continuous build waterfall script at https://github.com/WebAssembly/waterfall which does something similar.

binji commented 8 years ago

Yeah, maybe we should remove this repo? No one is updating it, and it is confusing when people find it and nothing works.

jfbastien commented 8 years ago

I'm not a fan of deleting things from the Internet. I'd rather have a warning :)