search

binkley / modern-java-practices

Modern Java/JVM Build Practices
Other
933 stars 69 forks source link

REMINDER: Remove compat6 PMD dependency when Maven PMD plugin updates #438

Closed binkley closed 3 months ago

binkley commented 5 months ago

The current Maven PMD plugin relies on classes from 6.x PMD. Gradle's PMD plugin does not have this concern.

PMD provides a "pmd-compat6" jar usable by the plugin to patch the differences. This needs removing once the PMD plugin catches up.

See pom.xml and:

<dependency>
    <groupId>net.sourceforge.pmd</groupId>
    <artifactId>pmd-compat6</artifactId>
    <version>${pmd.version}</version>
</dependency>

Without this, the plugin falls over. Tempting, but ./mvnw dependency:resolve-plugins does not reveal the problem.

binkley commented 3 months ago

Local build passes when removing this dependency, and after PMD version updates.