Clean up shell AST - Githubissues

angelhof commented 1 year ago

The goal of this PR is to implement the first step towards resolving #671.

[X] Introduce proper classes for all command AST nodes
[x] Create a function that transforms an untyped AST to a complete typed AST (eventually this will be moved to libdash)
[x] Make sure that PaSh always deals with the typed AST, and only makes it untyped before passing it to the unparser
[x] Clean up all obsolete code and comments

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Thu May 18 19:33:26 UTC 2023 intro: 2/2 tests passed. interface: 39/40 tests passed. compiler: 54/54 tests passed. agg: 109/109 tests passed. test10 are not identical

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Thu May 18 19:59:44 UTC 2023 intro: 0/2 tests passed. interface: 6/40 tests passed. compiler: 0/54 tests passed. agg: 10/109 tests passed. demo-spell.sh are not identical hello-world.sh are not identical test1 are not identical test2 are not identical test3 are not identical test4 are not identical test5 are not identical test6 are not identical test8 are not identical test9 are not identical test10 are not identical test12 are not identical test13 are not identical test14 are not identical test15 are not identical test16 are not identical test17 are not identical test18 are not identical test_set are not identical test_set_e are not identical test_redirect are not identical test_unparsing are not identical test_set_e_2 are not identical test_set_e_3 are not identical test_new_line_in_var are not identical test_cmd_sbst are not identical test_cmd_sbst2 are not identical test_cat_hyphen are not identical test_trap are not identical test_umask are not identical test_quoting are not identical test_var_assgn_default are not identical test_exclam are not identical test_redir_var_test are not identical test_star are not identical test_env_vars are not identical diff.sh are not identical diff.sh are not identical set-diff.sh are not identical set-diff.sh are not identical export_var_script.sh are not identical export_var_script.sh are not identical comm-par-test.sh are not identical comm-par-test.sh are not identical comm-par-test2.sh are not identical comm-par-test2.sh are not identical tee_web_index_bug.sh are not identical tee_web_index_bug.sh are not identical fun-def.sh are not identical fun-def.sh are not identical bigrams.sh are not identical bigrams.sh are not identical spell-grep.sh are not identical spell-grep.sh are not identical grep.sh are not identical grep.sh are not identical minimal_sort.sh are not identical minimal_sort.sh are not identical minimal_grep.sh are not identical minimal_grep.sh are not identical topn.sh are not identical topn.sh are not identical wf.sh are not identical wf.sh are not identical spell.sh are not identical spell.sh are not identical shortest_scripts.sh are not identical shortest_scripts.sh are not identical alt_bigrams.sh are not identical alt_bigrams.sh are not identical deadlock_test.sh are not identical deadlock_test.sh are not identical double_sort.sh are not identical double_sort.sh are not identical no_in_script.sh are not identical no_in_script.sh are not identical for_loop_simple.sh are not identical for_loop_simple.sh are not identical minimal_grep_stdin.sh are not identical minimal_grep_stdin.sh are not identical micro_10.sh are not identical micro_10.sh are not identical sed-test.sh are not identical sed-test.sh are not identical tr-test.sh are not identical tr-test.sh are not identical grep-test.sh are not identical grep-test.sh are not identical ann-agg.sh are not identical ann-agg.sh are not identical test-1 are not identical test-2 are not identical test-3 are not identical test-4 are not identical test-5 are not identical test-6 are not identical test-7 are not identical test-10 are not identical test-11 are not identical test-12 are not identical test-13 are not identical test-14 are not identical test-17 are not identical test-18 are not identical test-21 are not identical test-24 are not identical test-25 are not identical test-28 are not identical test-30 are not identical test-31 are not identical test-32 are not identical test-34 are not identical test-35 are not identical test-36 are not identical test-38 are not identical test-40 are not identical test-41 are not identical test-42 are not identical test-43 are not identical test-45 are not identical test-46 are not identical test-47 are not identical test-48 are not identical test-50 are not identical test-51 are not identical test-52 are not identical test-53 are not identical test-55 are not identical test-56 are not identical test-58 are not identical test-62 are not identical test-63 are not identical test-70 are not identical test-73 are not identical test-82 are not identical test-84 are not identical test-89 are not identical test-90 are not identical test-93 are not identical test-95 are not identical test-96 are not identical test-97 are not identical test-98 are not identical test-99 are not identical test-100 are not identical test-101 are not identical test-102 are not identical test-103 are not identical test-104 are not identical test-105 are not identical test-106 are not identical test-107 are not identical test-108 are not identical test-109 are not identical test-110 are not identical test-111 are not identical test-113 are not identical test-114 are not identical test-115 are not identical test-116 are not identical test-117 are not identical test-118 are not identical test-120 are not identical test-121 are not identical test-122 are not identical test-123 are not identical test-125 are not identical test-129 are not identical test-130 are not identical test-131 are not identical test-140 are not identical test-149 are not identical test-150 are not identical test-152 are not identical test-153 are not identical test-160 are not identical test-163 are not identical test-165 are not identical test-170 are not identical test-175 are not identical test-176 are not identical test-177 are not identical test-178 are not identical test-179 are not identical test-180 are not identical test-181 are not identical test-182 are not identical test-187 are not identical test-192 are not identical

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = 220b7359 Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	494	371	45	31	6	40	1
intro	2	2	0	0	0	0	0
interface	40	39	1	0	0	0	0
compiler	54	20	34	0	0	0	0
aggregator	109	109	0	0	0	0	0

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = 86f75e9c Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	494	371	45	31	6	40	1
intro	2	2	0	0	0	0	0
interface	40	39	1	0	0	0	0
compiler	54	54	0	0	0	0	0
aggregator	109	109	0	0	0	0	0

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Thu May 18 21:12:35 UTC 2023 intro: 2/2 tests passed. interface: 39/40 tests passed. compiler: 54/54 tests passed. agg: 109/109 tests passed. test10 are not identical

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = fe3a8e7c Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	306	234	21	14	1	35	1
intro	2	2	0	0	0	0	0
interface	40	39	1	0	0	0	0
compiler	54	54	0	0	0	0	0
aggregator	109	109	0	0	0	0	0

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Sat May 20 21:26:32 UTC 2023 intro: 2/2 tests passed. interface: 40/40 tests passed. compiler: 54/54 tests passed. agg: 109/109 tests passed.

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = 69465553 Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	494	375	41	31	6	40	1
intro	2	2	0	0	0	0	0
interface	40	40	0	0	0	0	0
compiler	54	54	0	0	0	0	0
aggregator	109	109	0	0	0	0	0

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Sat May 20 21:44:08 UTC 2023 intro: 2/2 tests passed. interface: 40/40 tests passed. compiler: 54/54 tests passed. agg: 109/109 tests passed.

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = 8f82286a Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	494	375	41	31	6	40	1
intro	2	2	0	0	0	0	0
interface	40	40	0	0	0	0	0
compiler	54	54	0	0	0	0	0
aggregator	109	109	0	0	0	0	0

github-actions[bot] commented 1 year ago

OS:ubuntu-20.04 Sat May 20 21:51:43 UTC 2023 intro: 2/2 tests passed. interface: 40/40 tests passed. compiler: 54/54 tests passed. agg: 109/109 tests passed.

github-actions[bot] commented 1 year ago

OS = Debian 10 CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz Ram = 15752 Hash = 3da8e4b6 Kernel= Linux 4.15.0-197-generic x86_64	benchmark	tests	passed	failed	untested	unresolved	unsupported
posix	494	375	41	31	6	40	1
intro	2	2	0	0	0	0	0
interface	40	40	0	0	0	0	0
compiler	54	54	0	0	0	0	0
aggregator	109	109	0	0	0	0	0

binpash / pash

Clean up shell AST #673