feat(net): add option -x to unshare network

binpash / try

Inspect a command's effects before modifying your live system

MIT License

5.18k stars 66 forks source link

feat(net): add option -x to unshare network #130

Closed ezrizhu closed 11 months ago

ezrizhu commented 11 months ago

This PR adds an option -x to unshare the network by adding --net to the first unshare invocation.

[x] add option to try
[x] add to unit test

eric@ide0:~/try$ ./try ip --brief link
lo               UNKNOWN        00:00:00:00:00:00 <LOOPBACK,UP,LOWER_UP>
ens18            UP             ce:b8:f6:2a:67:af <BROADCAST,MULTICAST,UP,LOWER_UP>
eric@ide0:~/try$ ./try -x ip --brief link
lo               DOWN           00:00:00:00:00:00 <LOOPBACK>

Note: I would use ping -c1 1.1 instead of curl 1.1 but #131

Closes #127

ezrizhu commented 11 months ago

Don't we need to also modify manpages and completions?

Oops I forgot about that, they have been pushed.

ezrizhu commented 11 months ago

Are the failing tests something to worry about?

Likely not! They’re failing due to #128