search

binpash / try

Inspect a command's effects before modifying your live system
MIT License
5.18k stars 66 forks source link

Add shellcheck functionality - attempt 2 #95

Closed yamanawabi closed 1 year ago

yamanawabi commented 1 year ago

Created simple workflow to run spellcheck, separate from main/test workflow. For issue #72

yamanawabi commented 1 year ago

Thanks, the workflow looks good! Could you rebase the PR to main and only have your commit in the PR? Also, could you attempt fixes based on the shellcheck warnings so that the workflow doesn't fail? If you are not sure about the fix for any of these warning we can try to fix it when one of us has some time.

I've edited the PR to rebase to main, would you like me to do a separate PR for the shell fixes or all in one go?

Thanks for your patience and encouragement.

-Y

angelhof commented 1 year ago

Thank you! I think the same PR makes more sense so that the CI is always passing the tests on main.