binref / refinery

High Octane Triage Analysis
Other
635 stars 63 forks source link

Add option to defang the protocol of urls #10

Closed baderj closed 2 years ago

baderj commented 2 years ago

Adds an option -p to the the defang unit to escape the protocol of urls. So http becomes hxxp and ftps becomes fxps.

This is another very common way of defaning urls.

This commit also ads the reverse for fxps and fxp

huettenhain commented 2 years ago

This latest MacOS sure slows down testing quite a bit.

codecov-commenter commented 2 years ago

Codecov Report

Merging #10 (7c891e5) into master (6bc00d9) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   83.77%   83.77%   -0.01%     
==========================================
  Files         258      258              
  Lines       15750    15754       +4     
==========================================
+ Hits        13195    13198       +3     
- Misses       2555     2556       +1     
Impacted Files Coverage Δ
refinery/units/pattern/defang.py 94.91% <100.00%> (+0.36%) :arrow_up:
refinery/units/meta/swap.py 85.71% <0.00%> (-2.17%) :arrow_down:
refinery/units/formats/pe/pemeta.py 86.03% <0.00%> (-0.31%) :arrow_down:
refinery/units/pattern/xtp.py 65.51% <0.00%> (ø)
refinery/units/formats/hexload.py 94.82% <0.00%> (ø)
refinery/units/misc/drp.py 91.12% <0.00%> (+0.07%) :arrow_up:
refinery/units/pattern/struct.py 82.14% <0.00%> (+0.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bc00d9...7c891e5. Read the comment docs.

huettenhain commented 2 years ago

How satisfying to merge a PR where all the CI automation worked splendidly. Thank you @baderj!