Closed baderj closed 2 years ago
Ah yes, I'll wait for the tests to pass and merge it. Thanks!
Merging #13 (d2aab07) into master (801c900) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 84.71% 84.71%
=======================================
Files 261 261
Lines 16376 16376
=======================================
Hits 13873 13873
Misses 2503 2503
Impacted Files | Coverage Δ | |
---|---|---|
refinery/units/formats/office/xlmdeobf.py | 92.30% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 801c900...d2aab07. Read the comment docs.
Thank you for the contribution! I made a few changes in bbb2b5cac95e20a6b8c4d0423644ea41e14aec10, removing some arguments that do not work with silent=True
and adjusting the overall style a little bit. Make sure I didn't render the unit unusable for you 😉. I have some changes locally that need some polishing, but I will push them soon and then make a new release so we have xlmdeobf
available via pypi.
Thanks for cleaning up the unit. Still works with the samples I have 👍
Only after the pull request #12 to add
xlmdeobf
had been merged, I noticed that I messed up the name of the class. Instead of naming it after the module (xlmdeobf
) I named itXLMMacroDeobfuscator
. This becomes the name of the command which is very hard to type.This pull request renames the class to
xlmdeobf
, so the name reflects the module name. This is consistent with other units that are all named with short lower case names.