binref / refinery

High Octane Triage Analysis
Other
635 stars 63 forks source link

iemap does not display colour #27

Closed cxiao closed 1 year ago

cxiao commented 1 year ago

Description

I have noticed that in my environment, the iemap unit does not produce any colour, which unfortunately makes the unit not very useful. Other units which produce colour, such as peek, do emit colour in their output as expected.

To Reproduce

This behaviour is reproducible on both Linux and MacOS. Just for reproducing this bug, I created a new Python virtual environment on both the Linux and MacOS machines, and did a fresh install of Binary Refinery inside it, via pip install binary-refinery[all].

I have included screenshots below of the output of the peek unit, as well as the iemap unit. I passed the --legend flag to iemap in this case, and expect to see colours in at least the numbered legend to the left of the entropy graph.

image

image

jhhcs commented 1 year ago

Yep, I can reproduce this. Working on a fix.

huettenhain commented 1 year ago

I think this should fix it. Once the deployment is through, would you mind updating to 0.6.1 and verify that it's working now? I am not at all sure my test is testing what I think it is testing. Hard to test for color.

cxiao commented 1 year ago

Looks good to me now on 0.6.1, on Linux 🌈:

image

cxiao commented 1 year ago

Good on macOS as well, on 0.6.1. I'm going to go ahead and close this issue now, thanks very much for fixing it!

image