search

binref / refinery

High Octane Triage Analysis
Other
635 stars 63 forks source link

Feature Request: Add Support for Converting from Base92 #48

Closed mosheDO closed 4 months ago

mosheDO commented 4 months ago

Consider adding support for converting from base92.

This addition would broaden its functionality and cater to users who may encounter data encoded in this format.

Regards, Moshe

huettenhain commented 4 months ago

What a crude and poorly documented encoding format. I added support in c2435fd4595826c7401559b68403bf1c7a7be3f1 and then wrestled the test suite for a bit. I will release a new version soon that includes the b92 unit for Base92 encoding and decoding.

mosheDO commented 4 months ago

Thanks for the effort, I looked on your commit (I'm not familiar with the project) But I think you have a typo mistake in your code

init.py

It supposed to be "Base92 encoded strings" instead of "Base64 encoded strings"

huettenhain commented 4 months ago

Ha, indeed, thanks. Fixed in a30cdea20d6d500ac0956482de2fc073fff602d1. Regardless, Base92 is now supported in version 0.6.39, so I will close out this issue. Cheers!