binsentsu / am43-ctrl

Node Util for controlling an AM43 Blinds Drive Cover, either over MQTT or via a HTTP API
44 stars 25 forks source link

Replace MQTT value_template with position_template #29

Closed provinzio closed 3 years ago

provinzio commented 3 years ago

Avoid deprecation warning from Home Assistant.

I am not sure whether we can keep value_template for backwards compatibility. This depends on how HA will handle this case with the next version. I'd remove value_template completly (like in the PR) to avoid problems in the future. HA has implemented position_template long enough, I guess.

The code is untested. I have no dev environment and am not firm enough with Node.js to check it. @binsentsu could you take a look into this? I'd really appreciate your help.

binsentsu commented 3 years ago

thanks!