binsync / libbs

A library for writing plugins in any decompiler: includes API lifting, common data formatting, and GUI abstraction!
BSD 2-Clause "Simplified" License
71 stars 6 forks source link

Add a multi-plugin config file #71

Closed Flipout50 closed 3 months ago

Flipout50 commented 5 months ago

closes #40

Flipout50 commented 5 months ago

@mahaloz does this seem like a correct start to you? I was getting a bit confused about plugin_path. We mentioned in our meeting that the config file should store the plugin path, but then in the issue it says the plugin holds arbitrary data keyed by plugin name. So does this mean that we have a general libbs.toml config that stores general libbs information, like headless paths, then also in it we store plugin specific data like plugin_path, last_project, and other arbitrary data under a plugin name by key? This is sort of what I started with the plugin_data dictionary.

mahaloz commented 5 months ago

@Flipout50 so I thought about this more, and I decided let's just make this config binsync specific, so we don't need to support "multi-plugins" anymore. We should at a minimum store the following:

Flipout50 commented 5 months ago

@mahaloz So would this PR be moved to binsync then

mahaloz commented 5 months ago

@Flipout50 nah let's do everything in LibBS with the knowledge that some things are specifically for BinSync. Maybe we can divide it up with a subclass or something?

mahaloz commented 4 months ago

@Flipout50 I'm sure you already knew, but you have a typo here: https://github.com/binsync/libbs/actions/runs/9392813976/job/25867723027#step:7:84